Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing potential crash #101 #122

Merged
merged 3 commits into from
Dec 9, 2020
Merged

Fixing potential crash #101 #122

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
092413f
Fixing potential crash
seriyvolk83 Nov 10, 2020
e2ba1ac
Adding check
seriyvolk83 Nov 10, 2020
0c9a76a
Handling flag properly
seriyvolk83 Nov 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 7 additions & 2 deletions ARVideoKit/Rendering/Writer/WritAR.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ class WritAR: NSObject, AVCaptureAudioDataOutputSampleBufferDelegate {
audioInput.expectsMediaDataInRealTime = true

audioBufferQueue.async {
self.session.startRunning()
self.session?.startRunning()
}

if assetWriter.canAdd(audioInput) {
Expand Down Expand Up @@ -208,7 +208,10 @@ class WritAR: NSObject, AVCaptureAudioDataOutputSampleBufferDelegate {
func captureOutput(_ output: AVCaptureOutput, didOutput sampleBuffer: CMSampleBuffer, from connection: AVCaptureConnection) {
if let input = audioInput {
audioBufferQueue.async { [weak self] in
if input.isReadyForMoreMediaData && (self?.isRecording)! {
if let isRecording = self?.isRecording,
let session = self?.session,
input.isReadyForMoreMediaData && isRecording
&& session.isRunning {
input.append(sampleBuffer)
}
}
Expand All @@ -227,6 +230,7 @@ class WritAR: NSObject, AVCaptureAudioDataOutputSampleBufferDelegate {
}

if assetWriter.status == .writing {
isRecording = false
assetWriter.finishWriting(completionHandler: finished)
}
}
Expand All @@ -237,6 +241,7 @@ class WritAR: NSObject, AVCaptureAudioDataOutputSampleBufferDelegate {
session.stopRunning()
}
}
isRecording = false
assetWriter.cancelWriting()
}
}
Expand Down