You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Fabric version of this mod contains an inject mixin in KeyMapping that is unconditionally cancelled. This is effectively the same as using an overwrite mixin, and is very bad practice:
if (!keyMapping.equals(EquipmentCompare.showComparisonTooltip))
{
MAP.put(keyMapping.key, keyMapping);
}
}
info.cancel();
}
Doing your mixin this way creates incompatibilities with one of my mods (specifically here (uses Yarn)) and is likely to create issues with other mods that modify keybind behaviour.
If possible, it'd be great if you could switch to a more limited injection scope, potentially making use of the excellent @WrapWithCondition provided by MixinExtras.
The text was updated successfully, but these errors were encountered:
The Fabric version of this mod contains an inject mixin in
KeyMapping
that is unconditionally cancelled. This is effectively the same as using an overwrite mixin, and is very bad practice:EquipmentCompare/src/main/java/com/anthonyhilyard/equipmentcompare/mixin/KeyMappingMixin.java
Lines 29 to 44 in 0e1fb08
Doing your mixin this way creates incompatibilities with one of my mods (specifically here (uses Yarn)) and is likely to create issues with other mods that modify keybind behaviour.
If possible, it'd be great if you could switch to a more limited injection scope, potentially making use of the excellent
@WrapWithCondition
provided by MixinExtras.The text was updated successfully, but these errors were encountered: