Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk/js): update artifacts #68

Closed

Conversation

cbrzn
Copy link

@cbrzn cbrzn commented Sep 19, 2023

This PR aims to support two endpoints that were missing from the Agent Protocol Specification in the JS SDK:

  • POST /agent/tasks/{task_id}/artifacts -> To upload artifacts for a given task
  • GET /agent/tasks/{task_id}/artifacts/{artifact_id} -> To download artifacts from a given task
  • GET /agent/tasks/{task_id}/artifacts -> Get the list of artifacts from a given task

It's worth mentioning that I've noticed that you started the migration of these SDK into their own repositories, but since it's a WIP I decided to open the PR here - If you feel that I should open the PR in the other repository just let me know (I also saw that it has some broken links).

I also have some questions regarding how the steps are handled - I noticed that in the Python SDK they're first created and the Status is defined as created but in JS we're not doing that; I updated it to be completed once the handler has finished but tbh I don't think this is handled okay, so I am looking for feedback here

Also, we're able to run a test suite in our agent with these changes. This is how I tested things 馃槃

@hackgoofer
Copy link
Contributor

hackgoofer commented Sep 20, 2023

oh amazing. @jzanecook and I will review. Thank you!
oh good catch on the broken links. The python SDK is definitely more mature than the JS one.
We appreciate your help. Taking a look now. :)

To your question: yes, we are planning to remove the SDKs from this repo into their respectable ones. We can do some code minor review here, but we'd love that you make Pull Requests against those other Repos instead. :)

Copy link
Collaborator

@jzanecook jzanecook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are great changes, and I look forward to testing them in the context of the testing suite.

If you can, @cbrzn can you remake this PR in the agent-protocol-sdk-js repo so we can keep it localized in there?

That will help us keep things organized.

@cbrzn
Copy link
Author

cbrzn commented Sep 21, 2023

PR migrated to AI-Engineer-Foundation/agent-protocol-sdk-js#1

@cbrzn cbrzn closed this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants