Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing :action tag #27

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Conversation

marcofavorito
Copy link
Member

Proposed changes

During the conversion from PDDL domain to string, the actions were printed without the :action tag. This PR adds the tag and removes the (wrong) upper-level tag :actions

Fixes

n/a

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Further comments

n/a

During conversion from PDDL domain to string,
the actions were printed without the ":action" tag.
This commit adds the tag and removes the (wrong)
upper level tag ":actions"
@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #27 (e1a948b) into develop (7c05194) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #27   +/-   ##
========================================
  Coverage    89.49%   89.49%           
========================================
  Files           19       19           
  Lines          790      790           
  Branches        71       71           
========================================
  Hits           707      707           
  Misses          64       64           
  Partials        19       19           
Flag Coverage Δ
unittests 89.49% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pddl/formatter.py 100.00% <ø> (ø)
pddl/core.py 93.07% <100.00%> (ø)

Copy link
Collaborator

@francescofuggitti francescofuggitti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marcofavorito marcofavorito merged commit b869df8 into develop Jun 30, 2021
@marcofavorito marcofavorito deleted the fix/domain-action-formatting branch June 30, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants