Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #81

Merged
merged 4 commits into from
Jun 6, 2023
Merged

Update dependencies #81

merged 4 commits into from
Jun 6, 2023

Conversation

marcofavorito
Copy link
Member

@marcofavorito marcofavorito commented Jun 6, 2023

Proposed changes

  • Update dev dependencies.
  • bump lark and click version lower-bounds to latest versions

Nothing breaks; looks good.

Fixes

n/a

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Further comments

n/a

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Merging #81 (b642823) into main (5530ceb) will not change coverage.
The diff coverage is n/a.

❗ Current head b642823 differs from pull request most recent head 61c4bcf. Consider uploading reports for the commit 61c4bcf to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage   89.67%   89.67%           
=======================================
  Files          22       22           
  Lines        1182     1182           
  Branches      193      193           
=======================================
  Hits         1060     1060           
  Misses         92       92           
  Partials       30       30           
Flag Coverage Δ
unittests 89.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@marcofavorito marcofavorito marked this pull request as draft June 6, 2023 06:37
@marcofavorito marcofavorito marked this pull request as ready for review June 6, 2023 12:52
This is not a strictly necessary change, but it is useful to find the minimum click version working across systems and to early detect dependency conflicts.
Copy link
Collaborator

@francescofuggitti francescofuggitti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@marcofavorito marcofavorito merged commit b25b3a4 into main Jun 6, 2023
10 checks passed
@marcofavorito marcofavorito deleted the update-deps branch June 6, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants