-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes and improvements in the parsing of typed lists #82
Merged
Merged
Changes from 50 commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
e3a249e
fix: remove constants.py module and use pddl/parser/symbols.py
marcofavorito 658dc62
fix: add missing __invert__ method for True/FalseFormula classes
marcofavorito d7d0534
test: fix blocksworld_fond/p01.pddl goal
marcofavorito d5b509c
chore: add 'check' function to generalize assert_ for any exception type
marcofavorito 3c53e3f
feat: add TypesIndex class
marcofavorito 3cf8cb4
feat: changing domain parser behaviour on typed_list_name (backward c…
marcofavorito cf25df5
test: add problem parsing in test_formatter.py
marcofavorito ccb5097
test: fix expected error messages when duplicated names/types occur
marcofavorito 7a7836c
fix: minor fix to object-supertypes-error
marcofavorito f1e3316
fix: use 'name' type to validate tokens of typed list
marcofavorito 48ffa56
chore: sort Symbols in alphanumerical order
marcofavorito 976f481
fix: add keyword validation for typed list names
marcofavorito 889b3fc
fix: renaming variables to avoid shadowing from outer scope
marcofavorito 73e4fac
feat: use TypesIndex to parse and validate typed_list_variables
marcofavorito d2dded9
test: split domain parser tests from problem parser tests
marcofavorito 67d3b1d
docs: fix types argument passed to Domain in README
marcofavorito 124a60a
fix: problem optionally accepts requirements
marcofavorito 03abf7d
lint: fix vulture's whitelist
marcofavorito 04fe2f8
feat: add internal class to manage and handle types
marcofavorito 1a35939
refactor: more Requirements to its own module pddl.requirements
marcofavorito c3ab1aa
chore: move _Types in pddl._validation
marcofavorito 35f333b
chore: return 'name' instead of str in domain/problem names property …
marcofavorito 529d35d
chore: used 'validate' instead of 'assert_'
marcofavorito 0d264a8
chore: add Problem.check method stub
marcofavorito 03e632b
chore: change the way requirements are set in a Problem object
marcofavorito f232127
fix: update domain setter of Problem
marcofavorito 1586db1
feat: add TypeChecker utility class and use it for checking (both dom…
marcofavorito e879efb
fix: improve Problem initialize regarding requirements and domain_nam…
marcofavorito 771c6fc
test: refactor parametrized tests
marcofavorito 2d35e8c
build: bump minimum Python interpreter supported to 3.8
marcofavorito 190a7c5
fix: minor fixes to requirements handling in core module
marcofavorito 4376e54
feat: add validation of domain/problem predicates
marcofavorito a511022
feat: add type validation of domain actions
marcofavorito 3d02538
refactor: move Action class in its own module core.action
marcofavorito 617cfd7
test: fix validation exception message
marcofavorito bdddfbf
feat: add keyword check
marcofavorito 7b3e7ad
test: add tests on wrong variable typed lists
marcofavorito a12e34b
fix: move keyword validation inside class contructors
marcofavorito f0e79af
fix: make find_cycle to handle arbitrary graphs
marcofavorito 8c41830
chore: rename TypesIndex to TypedListParser
marcofavorito eb2429d
feat: allow repetition in variable list
marcofavorito 9a16858
test: improve 'test_variables_repetition_allowed_if_same_type'
marcofavorito a6367ba
Update .github/workflows/docs.yml
marcofavorito 2c67fde
feat: add validation of no-duplicates in type-tags of a Term
marcofavorito b8e0a2b
feat: make Term non-instantiatable
marcofavorito 3661f64
feat: check terms consistency wrt type tag
marcofavorito 924c88c
feat: add term type checks in EqualTo class
marcofavorito f7996d1
test: add more tests for problem parsing
marcofavorito f5858b3
ci: change GH action version from master to main
marcofavorito edcc295
fix formatting of typed lists
marcofavorito 97b379f
fix: update error message in case a name inherits from multiple types
marcofavorito File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,13 +13,13 @@ jobs: | |
strategy: | ||
matrix: | ||
os: [ubuntu-latest] | ||
python-version: ["3.7", "3.8", "3.9", "3.10", "3.11"] | ||
python-version: ["3.8", "3.9", "3.10", "3.11"] | ||
|
||
timeout-minutes: 30 | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here? |
||
steps: | ||
- uses: actions/checkout@master | ||
- uses: actions/setup-python@master | ||
- uses: actions/checkout@main | ||
- uses: actions/setup-python@main | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
- name: Install dependencies | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we change:
to
main
as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes sure, thank you for spotting it