Issue 87

[francescofuggitti]

Fixes

This PR solves the issue #87

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

• I have read the CONTRIBUTING doc
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works

[codecov-commenter]

Codecov Report

Merging #90 (d61e692) into main (f54e187) will decrease coverage by 0.02%.
The diff coverage is 88.23%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   90.78%   90.77%   -0.02%     
==========================================
  Files          24       24              
  Lines        1389     1398       +9     
  Branches      245      247       +2     
==========================================
+ Hits         1261     1269       +8     
  Misses         93       93              
- Partials       35       36       +1     

Flag	Coverage Δ
unittests	90.77% <88.23%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
pddl/_validation.py	92.12% <100.00%> (+0.06%)	⬆️
pddl/parser/domain.py	83.17% <100.00%> (+0.31%)	⬆️
pddl/requirements.py	87.50% <83.33%> (-2.50%)	⬇️

[haz]

Just one minor question...

[haz]

I guess quantified preconditions covers both existential and universal, but under that path, wouldn't STRIPS cover all those here?

pddl/pddl/requirements.py

Line 42 in f54e187

Requirements.TYPING,

Actually, I'm a bit confused as to why those are all included in STRIPS...

[francescofuggitti]

Yes, quantified preconditions covers both universal and existential.

Thanks for pointing out the issue. I think it all depends on what reference we are following and what we want to achieve. At this moment, STRIPS covers some of the other requirements but shouldn't (based on the original version and the BNF). I don't remember why we put such additional requirements under STRIPS, but most probably to parse some domains that are not fully compliant with the original grammar... ?

[haz]

I'd probably flag it as an issue for the PDDL, and keep the pddl lib pure and true to the BNF. Want to tackle the slight rewrite of the STRIPS set in this PR, or open a new one?

[francescofuggitti]

Agree! I can do that here..

[haz]

Lgtm!