Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write sdc params to config.json upon finalise #111

Merged
merged 2 commits into from Jul 6, 2023

Conversation

rpreen
Copy link
Collaborator

@rpreen rpreen commented Jul 5, 2023

Resolves #108

Upon finalise() the parameters used for SDC checking are written to config.json - keeping it separate from the results.json seems cleaner.

Example config.json

{
    "safe_threshold": 10,
    "safe_dof_threshold": 10,
    "safe_nk_n": 2,
    "safe_nk_k": 0.9,
    "safe_pratio_p": 0.1,
    "check_missing_values": false
}

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #111 (0ccc0d4) into main (791a235) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 0ccc0d4 differs from pull request most recent head 60a6da6. Consider uploading reports for the commit 60a6da6 to get more accurate results

@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   96.97%   97.00%   +0.02%     
==========================================
  Files           5        5              
  Lines         629      634       +5     
==========================================
+ Hits          610      615       +5     
  Misses         19       19              
Impacted Files Coverage Δ
acro/acro.py 98.96% <100.00%> (+0.02%) ⬆️

@rpreen rpreen requested a review from jim-smith July 5, 2023 19:21
@jim-smith
Copy link
Contributor

@benbc assume this works from a GUI perspective?

@rpreen rpreen merged commit 0a25a95 into main Jul 6, 2023
2 checks passed
@rpreen rpreen deleted the 108_write_configuration_settings_to_json branch July 6, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add configuration settings to the JSON metadata
2 participants