Use Threading for MP pull parallelism #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewcarbone
force-pushed
the
mc/async
branch
2 times, most recently
from
8797251
to
0c709d8
Compare
matthewcarbone
force-pushed
the
mc/async
branch
from
0c709d8
to
ec9ff14
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #135 +/- ##
==========================================
+ Coverage 80.52% 80.58% +0.05%
==========================================
Files 13 13
Lines 1022 1025 +3
==========================================
+ Hits 823 826 +3
Misses 199 199
☔ View full report in Codecov by Sentry. |
matthewcarbone
force-pushed
the
mc/async
branch
2 times, most recently
from
d566bb4
to
6f20e5b
Compare
matthewcarbone
force-pushed
the
mc/async
branch
from
6f20e5b
to
693a4db
Compare
matthewcarbone
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #133
I think this could be interesting and very useful. I need to benchmark the timing but in principle the operation of pulling data shouldn't be CPU-bound, so this should speed things up.