-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cc compare spectra #242
Cc compare spectra #242
Conversation
Functions for comparing between spectra
Examples for using compare spectra functions
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #242 +/- ##
==========================================
- Coverage 67.87% 63.42% -4.46%
==========================================
Files 14 15 +1
Lines 1183 1266 +83
==========================================
Hits 803 803
- Misses 380 463 +83 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall very nice. Just a few nitpicks then I can merge. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the code looks good but we need to improve the documentation here a bit more. Docs should follow the NumPy style. @chuntian236, do you want to do this here or should we just open an issue and do it later?
Let me try to do this here. I might forget everything if I decide to do it later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is way better. Some nitpicks here and there but honestly I don't really mind merging at this stage.
Created "compare_utils.py" for spectra comparison and alignment:
https://github.com/AI-multimodal/Lightshow/blob/cc-compare-spectra/lightshow/postprocess/compare_utils.py
Jupyter notebook:
https://github.com/AI-multimodal/Lightshow/blob/cc-compare-spectra/notebooks/compare_spectra.ipynb