Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cc compare spectra #242

Merged
merged 12 commits into from
Feb 25, 2024
Merged

Cc compare spectra #242

merged 12 commits into from
Feb 25, 2024

Conversation

chuntian236
Copy link
Collaborator

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 83 lines in your changes are missing coverage. Please review.

Project coverage is 63.42%. Comparing base (d508d84) to head (19a1a04).
Report is 1 commits behind head on master.

Files Patch % Lines
lightshow/postprocess/compare_utils.py 0.00% 83 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
- Coverage   67.87%   63.42%   -4.46%     
==========================================
  Files          14       15       +1     
  Lines        1183     1266      +83     
==========================================
  Hits          803      803              
- Misses        380      463      +83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@matthewcarbone matthewcarbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall very nice. Just a few nitpicks then I can merge. Thanks!

lightshow/postprocess/compare_utils.py Outdated Show resolved Hide resolved
lightshow/postprocess/compare_utils.py Outdated Show resolved Hide resolved
lightshow/postprocess/compare_utils.py Outdated Show resolved Hide resolved
Copy link
Contributor

@matthewcarbone matthewcarbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code looks good but we need to improve the documentation here a bit more. Docs should follow the NumPy style. @chuntian236, do you want to do this here or should we just open an issue and do it later?

@chuntian236
Copy link
Collaborator Author

I think the code looks good but we need to improve the documentation here a bit more. Docs should follow the NumPy style. @chuntian236, do you want to do this here or should we just open an issue and do it later?

Let me try to do this here. I might forget everything if I decide to do it later.

Copy link
Contributor

@matthewcarbone matthewcarbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is way better. Some nitpicks here and there but honestly I don't really mind merging at this stage.

@matthewcarbone matthewcarbone merged commit 94fa2bb into master Feb 25, 2024
14 checks passed
@matthewcarbone matthewcarbone deleted the cc-compare-spectra branch February 25, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants