Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Poetry dependency #997

Merged
merged 1 commit into from
May 4, 2023
Merged

Conversation

dancju
Copy link
Contributor

@dancju dancju commented May 2, 2023

  • Upgraded Gym to Gymnasium Since SB3 will only support Gymnasium in the future. Some environment classes were upgraded because the API for reset() and step() was changed. We might want to update other environment classes as well.
  • Upgraded Python to 3.10 in order to fix the dependency issue.
  • Fixed minor bugs in Stock_NeurIPS2018_3_Backtest.ipynb and plot the backtesting results of all models (A2C, DDPG, PPO, TD3, SAC).

@zhumingpassional
Copy link
Collaborator

zhumingpassional commented May 4, 2023

what is the meaning of alpaca-trade-api = "^3"?
what is the advantage of using gymnasium instead of gym?

@dancju
Copy link
Contributor Author

dancju commented May 4, 2023

@zhumingpassional zhumingpassional merged commit 4060f59 into AI4Finance-Foundation:master May 4, 2023
@zhumingpassional
Copy link
Collaborator

ok. thanks very much for your codes and response.

@dancju
Copy link
Contributor Author

dancju commented May 4, 2023

I forgot to mention, I changed three env files because the return type for reset() and step() is changed under the new API, and we might want to update all the env classes.

@zhumingpassional
Copy link
Collaborator

yes. I see

wrds = ">=3.1.6"
alpaca-trade-api = "^3"
ccxt = "^3"
exchange-calendars = "^4"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this cause a regression fixed by #695

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants