Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag created by pipeline has a pr- prefix #56

Merged
merged 2 commits into from
Aug 25, 2020
Merged

Conversation

goern
Copy link
Member

@goern goern commented Aug 25, 2020

Related Issues and Dependencies

closes #55

This introduces a breaking change

  • Yes
  • No

Signed-off-by: Christoph Görn <goern@redhat.com>
@goern goern requested a review from harshad16 as a code owner August 25, 2020 18:12
@sesheta sesheta requested a review from fridex August 25, 2020 18:12
@goern goern removed the request for review from harshad16 August 25, 2020 18:12
@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 25, 2020
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this sound fix the issue.

@sesheta
Copy link
Contributor

sesheta commented Aug 25, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2020
@sesheta sesheta merged commit bddaf55 into AICoE:master Aug 25, 2020
@goern goern deleted the issues/55 branch August 26, 2020 02:17
goern added a commit that referenced this pull request Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The /deploy command should generate more descriptive tag
3 participants