This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
Refactoring code base to utilize better encapsulation #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesheta
added
the
size/XL
|
Build failed.
|
zak-hassan
force-pushed
the
refactor_a2
branch
from
73dac1a
to
92b8aa4
Compare
|
Build succeeded.
|
|
lgtm but this should require a 2nd approval, - @4n4nd thoughts? |
zak-hassan
force-pushed
the
refactor_a2
branch
2 times, most recently
from
ae364b0
to
6c35136
Compare
4n4nd
suggested changes
Oct 31, 2019
anomaly_detector/core/job.py
Outdated
| self.recreate_model = recreate_model | ||
|
|
||
| def execute_with_tracing(self, tracer): | ||
| """Will wrap execution of inference with tracer to measure latency.""" |
There was a problem hiding this comment.
It executes the training but wraps a tracer around it. This is needed to make tracing possible to measure how long for example Training takes.
There was a problem hiding this comment.
Yes sure, but the doc string says execution of inference and you're telling me it is the execution of training.
anomaly_detector/core/job.py
Outdated
| recreate_models = False | ||
|
|
||
| def __init__(self, node_map=24, model_adapter=None, recreate_model=True): | ||
| """Initialize inference job with fields to perform model training.""" |
There was a problem hiding this comment.
Fixed the comments.
There was a problem hiding this comment.
Docstring says inference, you say training
|
Build succeeded.
|
|
Build succeeded.
|
zak-hassan
force-pushed
the
refactor_a2
branch
from
a9f34a7
to
ea5c54b
Compare
|
Build failed.
|
zak-hassan
force-pushed
the
refactor_a2
branch
from
f93fe31
to
eb6e143
Compare
sesheta
added
the
approved
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Breaking up code and refactoring. Also include better docs.