Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow asymmetric tracking region, default to symmetric #1012

Conversation

wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Nov 10, 2022

At the EIC (and other asymmetric colliders) the detector layout is asymmetric. Thus, we wish to define asymmetric tracking regions. This PR introduces tracker_region_zmin which is the (signed) negative z position of the tracking region. If not specified, it is set to the negative of zmax and an info message is printed (ensuring backwards compatibility).

BEGINRELEASENOTES

  • DDG4: Geant4TCUserParticleHandler: Allow for asymmetric tracking region with tracker_region_zmin

ENDRELEASENOTES

@wdconinc wdconinc changed the title feat: allow asymmetry tracking region, default to symmetric feat: allow asymmetric tracking region, default to symmetric Nov 10, 2022
Copy link
Member

@andresailer andresailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The only thing I am wondering about is the new info print out, if that should be debug. But if no one objects I'll merge next week...

@wdconinc
Copy link
Contributor Author

wdconinc commented Nov 11, 2022

I'll change it to debug. I was also looking for other docs on this tracking region functionality, but couldn't find it. Are there any other locations it can be included under docs/?

@andresailer
Copy link
Member

There is some description in https://dd4hep.web.cern.ch/dd4hep/usermanuals/DDG4Manual/DDG4Manual.pdf section 5.3 Monte-Carlo Truth Handling

@wdconinc
Copy link
Contributor Author

I finally had some time to look at the section of the docs. It is more general in scope, not specifically about Geant4TCUserParticleHandler, so adding this asymmetric tracking region would require describing also this particular implementation of a Geant4UserParticleHandler. Therefore, I think it is probably fine to leave this as is.

@andresailer andresailer force-pushed the ddg4-particle-handler-asymmetry-tracking-region branch from 04c26d8 to 748b98b Compare November 24, 2022 14:49
@andresailer andresailer enabled auto-merge (rebase) November 24, 2022 14:49
@andresailer andresailer merged commit 95e0d4d into AIDASoft:master Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants