New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow asymmetric tracking region, default to symmetric #1012
feat: allow asymmetric tracking region, default to symmetric #1012
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The only thing I am wondering about is the new info print out, if that should be debug. But if no one objects I'll merge next week...
I'll change it to debug. I was also looking for other docs on this tracking region functionality, but couldn't find it. Are there any other locations it can be included under |
There is some description in https://dd4hep.web.cern.ch/dd4hep/usermanuals/DDG4Manual/DDG4Manual.pdf section 5.3 Monte-Carlo Truth Handling |
I finally had some time to look at the section of the docs. It is more general in scope, not specifically about |
Co-authored-by: Andre Sailer <andre.philippe.sailer@cern.ch>
04c26d8
to
748b98b
Compare
At the EIC (and other asymmetric colliders) the detector layout is asymmetric. Thus, we wish to define asymmetric tracking regions. This PR introduces
tracker_region_zmin
which is the (signed) negative z position of the tracking region. If not specified, it is set to the negative of zmax and an info message is printed (ensuring backwards compatibility).BEGINRELEASENOTES
tracker_region_zmin
ENDRELEASENOTES