Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard cmake way of defining package version #151

Merged
merged 2 commits into from May 7, 2017

Conversation

andresailer
Copy link
Member

These changes simplify the setting of the package version, so that the version only has to be defined in one place. This allows more automatic tagging of dd4hep, which needs to have the PACKAGE_VERSION_* variables be set in the main CMakeLists file.

Also change the variables in DDSegmentation to cmake like PACKAGE_VERSION_* (Will adapt tagging scripts to modify this file automatically as well and change ddsegmentation version via tagging script when making the tag on Monday...)

BEGINRELEASENOTES

  • Use cmake to create Version.h file to contain DD4hep version information and macros
  • Change the way DD4hep package version is defined and set standard cmake variables for this purpose

ENDRELEASENOTES

@MarkusFrankATcernch
Copy link
Contributor

I believe this is OK like this. The only question, which came to my mind was:
Does DDSegmentation really need it's own versioning?
In principle we anyhow at some point wanted to merge it into DD4hep.

@andresailer
Copy link
Member Author

No ddsegmentation doesn't need its own version. But changing the package structure was too much to do until Monday.

@andresailer andresailer merged commit 12c9317 into AIDASoft:master May 7, 2017
@andresailer andresailer deleted the cmakeStuff branch August 14, 2017 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants