Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to use
dd4hep::IOV
we found a things that could be improved:IOV::Key
was allowing for different types for the two bounds of the interval, but the feature was not used and could lead to weird situationsIOV::Key
waslong
, but that's not portable across architectures, so I changed it tostd::int64_t
BEGINRELEASENOTES
dd4hep::IOV
(using
instead oftypedef
,constexpr
instead ofenum
)dd4hep::IOV::Key
uniform wrt first and second typestd::int64_t
instead oflong
fordd4hep::IOV::Key
elementsENDRELEASENOTES