Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add builds against dev3, dev4 #728

Merged
merged 7 commits into from Nov 3, 2020
Merged

Conversation

andresailer
Copy link
Member

@andresailer andresailer commented Oct 27, 2020

This brings back the builds against dev3 and dev4, both are currently failing some tests
(dropping the others for debugging at the moment)

reminder (basically):
dev3: against root master
dev4: against root 6.22 patches
(http://lcginfo.cern.ch/compare_releases/x86_64-centos7-gcc8-opt/dev3/dev4)

@MarkusFrankATcernch @petricm Any idea why the failing tests?

Sadly github actions don't have an as nice allow failure as travis, so this needs to get figured out as well.

BEGINRELEASENOTES

  • CMake: fix python version compatibility check between python and root used for python. Add exception for CMake 3.17.1
  • Tests: fix some test configuration to run all tests after -D DD4HEP_BUILD_EXAMPLES=ON
  • Tests: fix tests for root 6.22.04 and master

ENDRELEASENOTES

@petricm
Copy link

petricm commented Oct 27, 2020

Is G__DDG4UserDict.cxx not present for the test? The dictionary has pragma for std::pair<double, std::vector<double> >

@MarkusFrankATcernch
Copy link
Contributor

The first test for sure failed due to the missing dictionary.
The crash is then due to an exception, which is unhandled (as it should be), a call to std::terminate,
which makes G4 crash on static destructors.
The original problem is the missing dictionary.

The second test does not really say why it fails, but it looks it is on the finalize
of the job without more specific details.

@andresailer
Copy link
Member Author

OK. I can fix the useranalysis test by creating the rootmap file for DDG4UserLib, so that library is loaded automatically.

cmake/DD4hepBuild.cmake Outdated Show resolved Hide resolved
@petricm
Copy link

petricm commented Nov 3, 2020

For the record why the exact python version check is necessary:

  • Python gives no guarantee for ABI compatibility of patch versions.
  • ROOT was bitten by Python-patch-release-not-binary-compatible a couple of times already

@andresailer
Copy link
Member Author

The only failing test is t_LHeD_DDG4_LHeDACLick_as_ACLick_LONGTEST . So when Markus confirms this fixes his problem as well, we can merge

@andresailer
Copy link
Member Author

Markus actually has 3.17.2 (#725 (comment)), added that to the check.

@andresailer andresailer merged commit 0ed07dc into AIDASoft:master Nov 3, 2020
@andresailer andresailer deleted the cidev branch November 3, 2020 12:39
vvolkl added a commit to vvolkl/EDM4HEP that referenced this pull request Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants