Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review generator python code #293

Merged
merged 7 commits into from
Jun 2, 2022
Merged

Review generator python code #293

merged 7 commits into from
Jun 2, 2022

Conversation

soumilbaldota
Copy link
Contributor

@soumilbaldota soumilbaldota commented May 31, 2022 •
edited
Loading

BEGINRELEASENOTES

  • Removing python2 compatibility imports
  • Removing ordered loading (obsolete) function

ENDRELEASENOTES

Fixes #292

@soumilbaldota soumilbaldota deleted the review_generator_python_code branch May 31, 2022 14:12
@soumilbaldota soumilbaldota restored the review_generator_python_code branch May 31, 2022 14:21
@soumilbaldota soumilbaldota reopened this May 31, 2022
@soumilbaldota @tmadlener
Update python/podio_config_reader.py
f32760b 
Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>
@tmadlener
Copy link
Collaborator

Hi @soumilbaldota, thanks for this. One thing I just realized while looking at your changes that I forgot to put the usage of OrderedDict into the original issue. Also this is mostly present for historical reasons and it should be safe to switch to regular dicts now (especially since they now also preserve insertion order). Could you also remove the usage of OrderedDict (and then obviously check that things still work)?

@tmadlener tmadlener merged commit e28f959 into AIDASoft:master Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review the generator python code
2 participants
@soumilbaldota @tmadlener