Build setup fixes #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove FCC specific setup script Factorise out environment setup (env.sh) to allow simple workflow users set PODIO themselves Make init.sh a very simple "out of the box" script
|
This fixes #33. I suggest "squash and merge" when accepting to keep the master branch tidy and suppress irrelevant fixup commits. |
gaede
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove FCC specific code from the
init.shscript (which breaks things for other users). This was discussed with @JavierCVilla and we agreed that any special FCC setup should be controlled by FCC directly (e.g. in the CI).Made the convenience scripts more generic and updated the instructions in
README.md.Factorised the environment setup to
env.shas this allows user to setPODIOthen use the script to set the requisite environment.BEGINRELEASENOTES
- remove FCC specific code from init.sh
- factorise environment setup to env.sh
- updated README.md
ENDRELEASENOTES