Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CANVAS.layers() doesn't include the impact layer and other generated layers #306

Closed
mbernasocchi opened this issue Oct 3, 2012 · 5 comments

Comments

@mbernasocchi
Copy link
Collaborator

as discussed here http://irclogs.geoapt.com/inasafe/%23inasafe.2012-10-03.log in test_dock.py when running a test, the CANVAS.layers() method does not return the generated layers.

@ghost ghost assigned timlinux Oct 3, 2012
@timlinux
Copy link
Contributor

@mbernasocchi can you update this? Is it still an issue we care about?

@mbernasocchi
Copy link
Collaborator Author

well, is not we really care about since CANVAS is a mock for test only. So, @timlinux up to you if you want to care or not. if you dont, please revert the commit and close the issue

@akbargumbira
Copy link
Member

Hi @mbernasocchi @timlinux, can we close this? Right now it includes the impact layer, or is it only for a specific case? Looking at the test, it all seems OK..

@akbargumbira
Copy link
Member

The canvas list before running analysis:

Padang WGS84
People
An earthquake in Padang like in 2009
Tsunami Max Inundation
Tsunami Building Exposure
A flood in Jakarta like in 2007
Penduduk Jakarta
An earthquake in Yogyakarta like in 2006
A flood in Jakarta
OSM Building Polygons
Essential buildings
Flood in Jakarta
roads Maumere
donut
Merapi Alert
kabupaten jakarta singlepart

After running the analysis:

After Padang WGS84
People
An earthquake in Padang like in 2009
Tsunami Max Inundation
Tsunami Building Exposure
A flood in Jakarta like in 2007
Penduduk Jakarta
An earthquake in Yogyakarta like in 2006
A flood in Jakarta
OSM Building Polygons
Essential buildings
Flood in Jakarta
roads Maumere
donut
Merapi Alert
kabupaten jakarta singlepart
People affected

@timlinux timlinux added the 2 label Sep 2, 2014
@timlinux timlinux added this to the Version 2.2 milestone Sep 2, 2014
@timlinux timlinux assigned mbernasocchi and unassigned timlinux Sep 2, 2014
@timlinux
Copy link
Contributor

timlinux commented Sep 2, 2014

IIRC we fixed this in the last release. @mbernasocchi please confirm and close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants