Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ordered dictionary is part of python 2.7 we ship our own (untested) #341

Closed
mbernasocchi opened this issue Oct 13, 2012 · 10 comments
Closed

Comments

@mbernasocchi
Copy link
Collaborator

since Python 2.7 an ordered dict is available in Python, we have our own in safe_qgis/odict.py. it is used by the keyword dialog only for now.
I need to start using it for the postprocessors, so I wonder whic one I should use? ours or Pythons?

I'll go with pythons, since the odict.py is test covered by 44%

os4geo qgis on windows runs 2.7 IIRC.

what do you think?

@ghost ghost assigned ismailsunni Oct 13, 2012
@timlinux
Copy link
Contributor

@mbernasocchi QGIS 1.7.4 on windows ships with python 2.5 so until we stop supporting it we need to use odict.

We can disable odict from coverage reports in the mean time though.

Regards

Tim

@mbernasocchi
Copy link
Collaborator Author

ok thanks @timlinux

@mbernasocchi
Copy link
Collaborator Author

not closing so we can come back when we drop support for 1.7.4

@timlinux
Copy link
Contributor

Also some Linuxes dont ship with 2.7 yet even if QGIS 1.8 is supported on them.

@uniomni
Copy link
Contributor

uniomni commented Oct 13, 2012

Yeah - it comes down to which Python versions come with QGIS

@uniomni
Copy link
Contributor

uniomni commented Oct 13, 2012

And btw, please - as suggested - exclude odict from coverage report as it isn't our code.

@mbernasocchi
Copy link
Collaborator Author

put odict into third_party and excluded third_party from coverage

@timlinux
Copy link
Contributor

We can do this but we will need to drop QGIS 1.7.x support which is fine since InaSAFE 2.0 will do this anyway.

@ghost ghost assigned timlinux Oct 23, 2013
@timlinux timlinux added the ready label Sep 2, 2014
@timlinux timlinux assigned cchristelis and unassigned timlinux Sep 2, 2014
@timlinux timlinux added the 3 label Sep 2, 2014
@timlinux
Copy link
Contributor

timlinux commented Sep 2, 2014

QGIS 1.8 is dead long live the king...lets do this

@mbernasocchi
Copy link
Collaborator Author

YAY! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants