get_git_changeset fails on windows

[timlinux]

Problem: When using a release type of 'alpha' a subprocess error is spawned when loading InaSAFE on Windows. I traced the problem back down to get_git_changeset.

Short term fix: Changing release state to beta or final solves the problem as these do not trigger a call to get_git_changeset

Long term fix: Figure out how to make this work sustainable on windows.

[timlinux]

Oh for clarity that issue is in safe.common.version.get_git_changeset()

[ismailsunni]

@timlinux tim, I think this issue occur again due this commit : bd5356b. Can you fix this?

[ismailsunni]

Somehow, that approach is failed again. It worked before.

For short term fix, I will check if it's Windows or Mac, and return something else, i.e. 'dev'.

[timlinux]

Can you confirm if your fix is in place @ismailsunni and close this out if it is?

[ismailsunni]

Hi @timlinux
I made some unit tests for this fix, and made a PR of it on #1349

I can confirm that it's fixed. Tested on Windows 7 and Ubuntu 14.04.