Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impact function modified - flood_OSM_building_impact #521

Closed
vanpuk opened this issue Mar 4, 2013 · 2 comments
Closed

Impact function modified - flood_OSM_building_impact #521

vanpuk opened this issue Mar 4, 2013 · 2 comments

Comments

@vanpuk
Copy link
Contributor

vanpuk commented Mar 4, 2013

In flood_population_evacuation you are able to modify the thresholds, in flood_OSM_building_impact you are not. It would be great to see the same functionality in both impact functions when relating to a flood model (raster).

I will be teaching InaSAFE in 2 weeks and would like to see this as part of a point release.
@ghost ghost assigned timlinux and ismailsunni Mar 4, 2013
@timlinux
Copy link
Contributor

timlinux commented Mar 4, 2013

Ismail will you take a look - let me know if you need any help.

ismailsunni added a commit that referenced this issue Mar 4, 2013
@ismailsunni
add depth threshold for #521 and pep8.
922e290
@vanpuk
Copy link
Contributor Author

vanpuk commented Mar 5, 2013

Checked and works perfectly!

@vanpuk vanpuk closed this as completed Mar 5, 2013
ismailsunni added a commit that referenced this issue Mar 13, 2013
@ismailsunni
cherry pick issue #521, add depth threshold
4db307f
@timlinux timlinux mentioned this issue Mar 18, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timlinux @vanpuk @ismailsunni