Add intermediate if class #1924
Conversation
|
@akbargumbira @cchristelis @timlinux |
|
This is not what I have in mind. The 12 classes shouldn't have calculate impact method. Running an IF is the job of the concrete IF. This is gonna be hard for the concrete IF to do its own analysis on calculating the impact. There's also too many layers of abstraction which I don't even understand the first time reading it.. |
|
But, let's hear other's opinion first @timlinux and @cchristelis |
|
@akbargumbira in that case, perhaps what you have in mind is just the layer checking here. Like, if we uses ContinuousVHClassifiedRE, we check that the hazard is a vector type and the exposure is raster? |
|
hi @akbargumbira |
…'t have IF inheritor
|
|
||
| @hazard_map.setter | ||
| def hazard_map(self, value): | ||
| """The classified hazard map by hazard type. Only valid for |
There was a problem hiding this comment.
First line of docstring should be single line followed by a full stop and a new line.
…ate_if_class Conflicts: safe/impact_functions/earthquake/earthquake_building/impact_function.py safe/impact_functions/generic/classified_raster_building/impact_function.py safe/impact_functions/inundation/flood_raster_osm_building_impact/impact_function.py safe/impact_functions/inundation/flood_raster_population/impact_function.py safe/impact_functions/inundation/flood_raster_road_qgis/impact_function.py safe/impact_functions/volcanic/volcano_point_population/metadata_definitions.py
|
Test fails because of layer_mode_none issues. |
Work In Progress, Don't merge yet.
Adds progressively 12 Intermediate Base Classes specified in #1914