Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license to 3-clause BSD #272

Merged
merged 2 commits into from Jul 17, 2017
Merged

Conversation

JoostJM
Copy link
Collaborator

@JoostJM JoostJM commented Jul 13, 2017

Addresses #268
Change the license to 3-clause BSD

Question: should there be a explicit statement "Not intended for clinical use" and if so, where should it go?
Possibilities:

  • Extra clause in the license
  • Statement at the top of the documentation
  • Statement at the top of ReadMe.md
  • Disclaimer in the log. (as a warning, and as such, will also be part of the output to the command window in default mode).

cc @Radiomics/developers

@fedorov
Copy link
Collaborator

fedorov commented Jul 13, 2017

Question: should there be a explicit statement "Not intended for clinical use" and if so, where should it go?

  • Extra clause in the license

@JoostJM no, I think it is not a good idea to add any extra clauses to the license. This will make the resulting license different from the 3-clause BSD, and will lead to a non-OSI-compliant license, obviating the purpose of license change.

See pointers to the relevant discussions that I included in #268 (comment). This specific issue you raise was discussed here. Quoting the license text, "[...] FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED". "clinical use" is just one of the possible uses, all of which are already disclaimed.

@pieper
Copy link
Contributor

pieper commented Jul 13, 2017

I agree with @fedorov we shouldn't change the wording of the license. The "not intended for clinical use" should be in places like the log file, the readme, and a header or comment of the output files.

@JoostJM
Copy link
Collaborator Author

JoostJM commented Jul 14, 2017

@pieper, @fedorov, I added a disclaimer to the github readme and to the top of the documentation.

@@ -1,199 +1,21 @@
Copyright 2017 Harvard Medical School
Copy link
Collaborator

@fedorov fedorov Jul 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoostJM @hugoaerts @pieper thinking about this for dcmqi, I decided to list BWH as the copyright holder, see https://github.com/QIICR/dcmqi/blob/master/LICENSE.txt. The reason is that, in case of dcmqi, BWH is the recepient of the award from NIH. It might make sense to list DFCI here, since in the case of pyradiomics, DFCI is the recipient of the main award funding pyradiomics development.

@hugoaerts
Copy link
Member

hugoaerts commented Jul 14, 2017 via email

@JoostJM JoostJM merged commit f2cbd3d into AIM-Harvard:master Jul 17, 2017
@JoostJM JoostJM deleted the update-license branch July 17, 2017 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants