Remove 32 bit support #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 What do you think of logging an Exception if a 32-bit runtime is detected ? |
fedorov
approved these changes
Oct 9, 2017
JoostJM
force-pushed
the
remove-32-bit-support
branch
from
5701b38
to
16ae1fe
Compare
When using PyRadiomics in 32 bits architecture, memory errors can arise when extracting large masks, or many small ones (see also AIM-Harvard#303). Therefore, remove support for 32 bits architecture by raising an exception when trying to install PyRadiomics on 32 bits architecture. Update documentation accordingly.
JoostJM
force-pushed
the
remove-32-bit-support
branch
from
16ae1fe
to
e6227f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using PyRadiomics in 32 bits architecture, memory errors can arise when extracting large masks, or many small ones (see also #303).
Therefore, remove support for 32 bits architecture by raising an exception when trying to install PyRadiomics on 32 bits architecture.
Update documentation accordingly.
Reformat
setup.pyscript to adhere to editorconfig settingscc @Radiomics/developers, @michaelschwier