Change calculation of filter correction coefficients #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update coefficients to use `max(|x|)`, instead of `max(x)` (use the absolute values). This prevents invalid calculation, as `max(x)` can be negative (impossible sqrt in square filter). Furthermore, this defines the range to be scaled to the larges difference from 0, instead of just the maximum value (which can yield very different ranges).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update coefficients to use
max(|x|), instead ofmax(x)(use the absolute values). This prevents invalid calculation, asmax(x)can be negative (impossible sqrt in square filter). Furthermore, this defines the range to be scaled to the largest difference from 0, instead of just the maximum value (which can yield very different ranges).