Remove python equivalents for c functions #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Python calculation from `test_cmatrices.py`. Instead, compare to baseline files (binary numpy array files). Additionally, rename the script to `test_matrices.py`. Update and move the script to add a new baseline to the tests folder, so that it can utilize the testUtils module during generation of a new baseline. The updates now include the generation of a baseline matrix file if the class contains the appropriate function (`_calculateCMatrix`).
Remove Python Texture matrix calculation: - GLCM - GLRLM - GLSZM - GLDM - NGTDM Remove Python surface area calculation Remove Python `GenerateAngles()` Remove parameters associated with enabling/disabling C Extensions Update warning messages displayed when C extensions fail to load. Update examples. Update documentation.
JoostJM
force-pushed
the
remove-python-equivalents-for-c-functions
branch
from
93dc12c
to
0c80bdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Python Texture matrix calculation:
Remove Python surface area calculation
Remove Python
GenerateAngles()Remove parameters associated with enabling/disabling C Extensions
Remove Python calculation from
test_cmatrices.py. Instead, compare to baseline files (binary numpy array files).Additionally, rename the script to
test_matrices.py.Update and move the script to add a new baseline to the tests folder, so that it can utilize the testUtils module
during generation of a new baseline. The updates now include the generation of a baseline matrix file if the class
contains the appropriate function (
_calculateCMatrix).Update warning messages displayed when C extensions fail to load.
Update examples.
Update documentation.
cc @Radiomics/developers