ENH: Add support for using a fixed bin count #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostJM
force-pushed
the
add-binCount-support
branch
from
2594029
to
c92e23b
Compare
|
I have to say, as a user, I could be confused reconciling the guidelines from IBSI (see below from v6 p.12) and strong recommendation not to use fixed bin number in pyradiomics.
In any case, good to see this feature, since we had questions about it several times now! |
JoostJM
force-pushed
the
add-binCount-support
branch
2 times, most recently
from
4620d68
to
4bb5814
Compare
In most literature on Radiomics to date, gray value discretization is done using either a fixed bin count or a fixed bin width. Although there is consensus on the need for discretization prior to texture-feature calculation, there is no definitive evidence favouring either the fixed bin count or fixed bin width method in a general application. There is some literature available showing a better reproducibility using a fixed bin width for features extracted from PET imaging. On the other hand, in many studies a fixed bin count is used. At PyRadiomics, we recommend using a fixed bin width, but implement a fixed bin count for completeness. See [this FAQ topic](http://pyradiomics.readthedocs.io/en/latest/faq.html#radiomics_fixed_bin_width) for a more detailed explanation of our rationale for recommending usage of a fixed bin width. Additionally, update the documentation to reflect the new voxel-based extraction functionality.
JoostJM
force-pushed
the
add-binCount-support
branch
from
4bb5814
to
885f981
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For extra compatibility allow user to extract using a fixed bincount.
Include a warning when fixed bincount is used to show the recommendation for a fixed bin width.
See this FAQ topic for more details.