ADD: Add GLCM Maximal Correlation Coefficient #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostJM
force-pushed
the
add-maximal-correlation-coefficient
branch
3 times, most recently
from
1da28ee
to
703d37b
Compare
Add the 14th Haralick feature to the GLCM. Add baseline for this feature and update documentation accordingly. Additionally, simplify eigenValue calculation in shape.py (instead of numpy.linalg.eigval, call numpy.linalg.eigvals, which only returns eigenvalues and not the eigenvectors (not used)).
Also document the equality of HXY1 and HXY2 (both equal to HX + HY), and their relationship with mutual information (I = HX + HY - HXY). Add the expected ranges of values. Fix typos in the rendering of the MCC formula.
JoostJM
force-pushed
the
add-maximal-correlation-coefficient
branch
from
703d37b
to
0a5a7d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the 14th Haralick feature to the GLCM.
Add baseline for this feature and update documentation accordingly.
Additionally, simplify eigenValue calculation in shape.py (instead of
numpy.linalg.eig, callnumpy.linalg.eigvals, which only returns eigenvalues and not the eigenvectors (not used)).cc @Radiomics/developers