Update c extensions #463
Merged
Update c extensions #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostJM
force-pushed
the
update-c-extensions
branch
from
c5ff2b3
to
f0a9e5a
Compare
This was referenced Feb 18, 2019
Rewrite the functions to be dimension unaware. For testing purposes, number of dimensions are hardcoded in the python wrapper and additional output is printed.
- Update checks from ensuring NDim = 3 to NDim(image) == NDim(mask) - Parse out number of dimensions from image array and use it to instantiate the size and strides arrays - Switch calloc for malloc (no need to have the arrays initialized. - Switch the loops for initializing the texture arrays for a `memset` statement
At certain places only a specific (range of) dimension(s) is allowed (e.g. local binary pattern filter). At those places, a check is implemented, preventing calculation if the dimensionality is wrong. Additionally, add the dimensionality to the output as part of the diagnostic features.
- Move parsing of distances and building the angles array to a separate function - Move the conversion of image and mask objects to the try_parse_arrays function
JoostJM
force-pushed
the
update-c-extensions
branch
from
f0a9e5a
to
9b7e5cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update C extensions to make extraction N-Dimensional