BUG: Fix out-of-range check in glszm C calculation #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calculating the GLSZM matrix, processed voxel indices are temporarily stored in the `processedStack`, and the current position in stored in `processed_idx`. To ensure no overflow errors occur, the `processed_idx` value is compared to the maximum size of `processedStack` (=equal to `Ns`) prior to pushing an index. This index is used, and then increased, meaning that if it's value = Ns - 1, it is still valid (though the last index to be valid). However, the check compared value + 1 >= Ns, which would fail in this last case. Update the check to allow this value.
This was referenced Sep 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calculating the GLSZM matrix, processed voxel indices are temporarily stored in the
processedStack, and the current position in stored inprocessed_idx. To ensure no overflow errors occur, theprocessed_idxvalue is compared to the maximum size ofprocessedStack(=equal toNs) prior to pushing an index.This index is used, and then increased, meaning that if it's value = Ns - 1, it is still valid (though the last index to be valid). However, the check compared value + 1 >= Ns, which would fail in this last case. Update the check to allow this value.
Fixes #615 and #617