BUG: Update CI and tests #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
JoostJM
commented
May 17, 2023
JoostJM
commented
- MacOs build support was added to CircleCI, and free plans are no longer available on TravisCI. Therefore move the MacOs build to CircleCI
- Add Python 3.8 and 3.9 support
- Switch to use of pytest instead of nose (deprecated)
- Fix bug in selecting the label_channel based on input csv in batchprocessing
- Force label and label_channel to int for compatibility with SimpleITK
Allow for newer versions to be used. Consistency in results is covered by testing.
Both label and label_channel are used in SimpleITK, which is more sensitive to datatypes (i.e. will fail when either parameter is int64_t). Therefore, force these values to int.
Label_channel was added to support 3D slicer's Segmentation format. However, with newer versions, Segmentations created in 3D slicer may be stored as labelmaps (more space efficient). Add a note to point users to this in `getMask` function.
Fix new definition of long description to ensure it is rendered on PyPi
Update status badges in readme to reflect new CI integration.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.