Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error handling #4

Open
faroit opened this issue May 7, 2021 · 0 comments
Open

Better error handling #4

faroit opened this issue May 7, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@faroit
Copy link
Collaborator

faroit commented May 7, 2021

we assume that the sample rates of the signals and the length of the references and estimates are the same. However often, users might not be aware of this and it would make sense to warn them already in the local test submission.

we have:

reference, _ = sf.read(reference_file)
estimate, _ = sf.read(estimate_file)

I think we should add

  • a check of the sample rates (the second argument _) these should the same (int(reference_rate) == int(estimate_rate))
  • a check of the shape of the files (reference.shape == estimate.shape)
@faroit faroit added the enhancement New feature or request label May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants