Solved issue #6: Ambiguous sentToDisplay(). Updated README.md

AKJ7 · Dec 30, 2020 · f4051bf · f4051bf
1 parent 8140f0e
commit f4051bf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -1,6 +1,8 @@
 # TM1637
 
-TM1637 Library Driver for Microcontrollers  
+TM1637 Library Driver for Microcontrollers.  
+Warning!!! The TM1637 requires 5V at the DIO and CLK input. Hence connecting it the display to an 3.3 V Controller Board like the ESP32 will not work.
+Interfacing the 3.3V output of the DGIO pins of the board to 5V is recommended.
 
 ## Features  
 - Supports integers, float and string displaying  

diff --git a/src/TM1637.h b/src/TM1637.h
@@ -178,18 +178,15 @@ class TM1637 {
         mI2C_.beginTransmission();
         mI2C_.send(static_cast<uint8_t>(addressCommand));
         for (decltype(size) counter{}; counter < size; ++counter)
-        {
             (colon_ || (dp_ & (1u << counter))) ? mI2C_.send(values[counter] | 0x80u) : mI2C_.send(values[counter]);
-        }
-
         mI2C_.endTransmission();
         mI2C_.beginTransmission();
         mI2C_.send(static_cast<uint8_t >(brightness_));
         mI2C_.endTransmission();
     }
 
     template <DataCommand_e dataCommand, AddressCommand_e addressCommand, typename ... Ts>
-    void sendToDisplay(Ts ... values) const noexcept
+    void sendToDisplayRaw(Ts ... values) const noexcept
     {
         mI2C_.beginTransmission();
         mI2C_.send(static_cast<uint8_t >(dataCommand));