Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Model for storing Pings #40

Closed
white-gecko opened this issue Nov 26, 2012 · 5 comments
Closed

Use Model for storing Pings #40

white-gecko opened this issue Nov 26, 2012 · 5 comments

Comments

@white-gecko
Copy link
Member

Use the default model to store incoming Pingback pings rather than the SQL database.

@ghost ghost assigned white-gecko Nov 26, 2012
@seebi
Copy link
Member

seebi commented Jan 10, 2013

please use the config ping.modelUri option URL value to define the ping log graph

@white-gecko
Copy link
Member Author

From the mail:

  1. Should I add the Pings to "http://localhost/OntoWiki/Config/"
  2. Should I add a new graph e.g. "http://localhost/Erfurt/Pings/"

Maybe you should configure 2. for the erfurt default.ini and 1. for the ontowiki default.ini (also 1. can be the hardcoded fallback value)

ac.modelUri is also http://localhost/OntoWiki/Config/ in Erfurt. Either we introduce a new model http://localhost/Erfurt/Config/ or I use 1. for OntoWiki and Erfurt.

Another question:
should I add a method which deletes the old ping SQL table or should I just leave it?

@white-gecko
Copy link
Member Author

I've added the changes to a new branch: https://github.com/AKSW/Erfurt/blob/feature/pingback/library/Erfurt/Ping.php after testing it, I will add a pull request.

@white-gecko white-gecko mentioned this issue Jan 10, 2013
7 tasks
@white-gecko
Copy link
Member Author

The pingback in branch https://github.com/AKSW/Erfurt/tree/feature/pingback is read to be merged. Should I sqash it or send all commits?

@white-gecko
Copy link
Member Author

Ok, I've rebased all the stuff and put it into two logical commits

@seebi seebi closed this as completed in c43c0f0 Aug 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants