Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pingback: change pingback to use model for storing pings. Fixes #40 #45

Merged
merged 4 commits into from
Aug 14, 2013

Conversation

white-gecko
Copy link
Member

This feature branch fixed issue #40 by storing the ping in a model (config option)
furthermore it fixes some issues which occurred in the pingback (separate commit)

@seebi
Copy link
Member

seebi commented Jan 14, 2013

Can I ask you to add some tests?

@white-gecko
Copy link
Member Author

Yes you can, but I don't really know how to use the test environment for this. I need a store with two models, where one already contains a resource. And I need predictable output from the internet or the wrapper.

But for sure this would be helpful to have a test, because I want to add further features. Maybe we can use this as an example for a testing workshop :-)

@white-gecko
Copy link
Member Author

I wrote two tests which succeed when running with phpunit Erfurt/PingTest.php inside tests/unit/ but there is a problem with Versioning if I run it with make test-unit which I don't understand.

Maybe @pfrischmuth could take a look at the tests?

@seebi
Copy link
Member

seebi commented May 13, 2013

@pfrischmuth Can we merge this?

seebi added a commit that referenced this pull request Aug 14, 2013
Feature/pingback: change pingback to use model for storing pings. Fixes #40
@seebi seebi merged commit c43c0f0 into develop Aug 14, 2013
@seebi seebi deleted the feature/pingback branch August 14, 2013 15:01
@seebi seebi restored the feature/pingback branch August 14, 2013 15:05
@seebi
Copy link
Member

seebi commented Aug 14, 2013

can not merge since make testfailes:
...................................................PHP Fatal error: Call to a member function getUri() on a non-object in /Users/seebi/Projects/OntoWiki.git/libraries/Erfurt/library/Erfurt/Versioning.php on line 606

@white-gecko
Copy link
Member Author

That is the problem, which I have to discuss and examine with @pfrischmuth

@white-gecko white-gecko mentioned this pull request Jan 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants