Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor development environment #364

Merged
merged 2 commits into from Jul 22, 2016
Merged

Conversation

pfrischmuth
Copy link
Contributor

This feature removes the old vagrant based development environment and adds support for a new docker based development environment.

The new environment is host in an external repo here: https://github.com/pfrischmuth/ontowiki-devenv.

Developers can use make devenv to clone the repo into their OntoWiki checkout.

@pfrischmuth pfrischmuth added this to the 1.0 milestone Jul 21, 2016
@white-gecko
Copy link
Member

I don't know if it is a good idea to also change the default settings in config.ini.dist to something devenv related, since this is also the default for normal OntoWiki setup

@pfrischmuth
Copy link
Contributor Author

Ok that's a valid point... I will revert the changes to the dist config files and will embed them into the devenv repo...

- Remove vagrant related files
- Remove vagrant stuff from .gitignore, ignore devenv folder
- Remove vagrant related targets
- Add devenv clone target to Makefile
- Change default database name for mysql tests
- Add copy of dist config files to devenv target in Makefile

Revert dist configs
@white-gecko
Copy link
Member

white-gecko commented Jul 22, 2016

  • manual review commits
  • check unit tests: OK (86 tests, 151 assertions)
  • check integration tests virtuoso: Tests: 27, Assertions: 138, Errors: 1. (was before)
  • check integration tests mysql: OK (27 tests, 139 assertions)

@white-gecko white-gecko merged commit 1003739 into develop Jul 22, 2016
@white-gecko white-gecko deleted the feature/refactor-devenv branch July 22, 2016 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants