Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor update to the schema exclude order for the CLI case #94

Merged
merged 1 commit into from
Dec 7, 2018

Conversation

chile12
Copy link

@chile12 chile12 commented Dec 7, 2018

Description

  • Schema exclusion was performed after applying explicitly included schemata, which resulted in confusing behaviour (especially in the default case, excluding owl when explicitly requested)
  • in addition the default schemata directory was not copied to the validate module and therefore not available in the CLI case

How Has This Been Tested?

is covered by the ValidateUtilsTest

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jimkont jimkont merged commit 4240c7b into master Dec 7, 2018
@jimkont
Copy link
Member

jimkont commented Dec 7, 2018

👍 thanks @chile12 !

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 55.916% when pulling 17725cb on fix/CliExcludeBehaviour into 133e9d6 on master.

@jimkont jimkont deleted the fix/CliExcludeBehaviour branch June 8, 2019 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants