Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conf_unfolder not working with list and grid params together. #66

Closed
L1nusB opened this issue Dec 15, 2022 · 3 comments · Fixed by #69
Closed

conf_unfolder not working with list and grid params together. #66

L1nusB opened this issue Dec 15, 2022 · 3 comments · Fixed by #69

Comments

@L1nusB
Copy link

L1nusB commented Dec 15, 2022

Hi,
the last commit that added the debug convenience features, I ran into an issue when trying to use both list and grid parameters in the configuration yaml that worked before.
After some digging I found that the issue seems to be caused during expand_experiments in conf_unfolder.py where the expansion of the experiment_configs in line 65-66 is conditioned on whether debug is True or False but the list splicing returns an empty list if debug is set to False as conditioning in the indicing process does not seem to work as the author expected (at least on my system):

experiment_configs += params_combine(
                config, key, iter_func)[:1 if debug else 0:]

I resolved this issue locally by doing it the same way it is done in the other cases by factoring it out and conditioning later:

expansion = params_combine(config, key, iter_func)

experiment_configs += expansion[:1] if debug else expansion
@LiXiling
Copy link
Collaborator

Thanks for opening this issue!
Let me make a small fix. Do you have time to try and test it afterwards?

LiXiling added a commit that referenced this issue Dec 15, 2022
@LiXiling
Copy link
Collaborator

Could you test the branch fix/issue66 ?

@L1nusB
Copy link
Author

L1nusB commented Dec 17, 2022

I tested the fix on branch fix/issue66 and it resolved the issue that was occuring for me.
Now all combinations of list/grid work fine again.
Thanks for your fast response.

@LiXiling LiXiling linked a pull request Jan 20, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants