Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

idea: add page for type chart #761

Open
yash-seth opened this issue Oct 5, 2022 · 2 comments
Open

idea: add page for type chart #761

yash-seth opened this issue Oct 5, 2022 · 2 comments
Assignees
@yash-seth
Labels
good first issue Good for newcomers Hacktoberfest

Comments

@yash-seth
Copy link

I had an idea for the website. A separate webpage for a type chart. A type chart is essentially a table which represents the effectiveness of a pokemon type against all the other typed pokemons. So, it's addition could be useful and neat. Presently, I just have the idea of having an centered image for this on the webpage type-chart.html .
@yash-seth yash-seth mentioned this issue Oct 5, 2022
Open
@AM1CODES
Copy link
Owner

AM1CODES commented Oct 6, 2022

Okay. Sounds cool to me, would love to see what you can come up with.

@yash-seth
Copy link
Author

Hey, I've raised a PR #762 which implements this. Have a look and get back to me if you have any suggestions or any changes are required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yash-seth yash-seth

Labels
good first issue Good for newcomers Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AM1CODES @yash-seth