Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implements the type chart feature #762

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

yash-seth
Copy link

This PR implements #761 . Kindly let me know if any changes are required, or if you have any suggestions. Thanks!

@yash-seth
Copy link
Author

image
Here is a demo of how it looks like.

@AM1CODES
Copy link
Owner

AM1CODES commented Oct 6, 2022

Can we present this data in a better way? Its more like an image added to the centre of the page.

@yash-seth
Copy link
Author

image

I've added in a heading to introduce the image.

@AM1CODES
Copy link
Owner

AM1CODES commented Oct 6, 2022

Hey man, i would really appreciate it if you could spend a little more time on this and actually make that whole table with code on the page. Inserting that image would take a lot of effort but i think implementing that table layout will and you can maybe learn some new stuff while figuring that out.

@yash-seth
Copy link
Author

yash-seth commented Nov 1, 2022

Hey @AM1CODES , I have implemented the code for the type chart feature. I apologise for the delay, I got caught with some college work. Have a look and let me know if any changes are required.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants