Upgrade to Modelica 4.0.0 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most changes in
PNlibare different formatting done by the conversion script. As the files now have more uniform formatting I think we should keep those changes.The updates to
Testingwere checked with the latest nightly omc v1.22.0-dev-255-gdedd489acd-cmake:Some models don't have issues with Tearing anymore, which is nice.
PNlib.Examples.Models.FiliP.ModellStationen.Station1.mosfails in the FrontEnd with error messageThis seems to be a valid error and the model should be fixed I suppose. I removed it from the list of
TESTFILESfor now.PNlib.Examples.ExtTest.ArcswithPCtoTC3fails to verify. I'm not familiar with the expected results so I can't say if it got better or worse.