Run a central Monitor service #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will use the same NodeMonitors as the edge monitor, but will be driven from the ConfigDB instead of from k8s.
It's not just running at the edge now. This requires a corresponding change in edge-helm-charts.
This will make diffs easier to understand in the future.
This watches the ConfigDB for Cluster Status entries.
Let's try creating this service principal the New Way, via a krbkey.
Pull in the new rx-util, we need it for mapStartStops. Remove utilities and replace with service-client, we don't need any server-side code.
Waiting for packets with rx.timeout() has the problem that once you've timed out you stop watching for packets. So if a packet comes in during our jitter delay, we won't see it. It also causes a lot of subscription and unsubscription if nothing else is watching the device. Use switchMap instead, like the offline logic.
This is too big a hammer really, but I'm not making a lot of redundant requests here. Without this the ConfigDB notifications are useless, as we just get back a cached result.
Passing the revision build arg into the environment causes cache invalidation for all RUN lines in the container. (Docker can't guess nothing uses the environment.)
* Move central config fetching into a method. * Remove some unnecessary logging.
* Make sure we don't publish before DBIRTH or after DDEATH. * Accept Rebirth DCMD. * Publish Rebirth metrics in our BIRTHs.
Make sure we don't claim to be monitoring a cluster when we are not.
Move the factory function into the NodeSpec; it appears to be impossible to sensible resolve a circular import in JS.
amrc-benmorrow
force-pushed
the
bmz/central-monitor
branch
from
d107476
to
c0268b4
Compare
AlexGodbehere
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run a central instance of the Monitor. This monitors the other monitors and raises Alerts if a cluster goes offline altogether, or if the cluster monitor is not functioning correctly for some reason.
Closes: #233