Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge PLM and PPM tracing routines #149

Closed
zingale opened this issue Aug 4, 2017 · 3 comments
Closed

merge PLM and PPM tracing routines #149

zingale opened this issue Aug 4, 2017 · 3 comments

Comments

@zingale
Copy link
Member

zingale commented Aug 4, 2017

The basic structure of the characteristic tracing is the same for PLM and PPM, but we have separate tracing routines. We should merge these together.

@zingale
Copy link
Member Author

zingale commented Aug 11, 2017

also, should we trace all the source terms? If you look in trace_nd.F90, it considers sources for all quantities, not just velocity (in 1-d)

@zingale
Copy link
Member Author

zingale commented Sep 3, 2017

this is actually quite easy. We can get rid of the PLM routines and instead define and I(nu) as

I(nu) = q_i + 1/2 (1 - dt/dx lambda(nu) ) dq_i

for the left state (and an analogous one for the right state), and then just use this in the PPM tracing routines instead of the integrals under the parabola.

Then, we define the reference state as it is currently done with PLM, e.g., for the left state,

q_ref = q_i+ 1/2 (1 - dt/dx max(lambda(+),0)) dq_i

Otherwise, all the remaining operations will be the same as with the PPM, so this really simplifies the codes.

@zingale zingale self-assigned this Sep 3, 2017
@zingale zingale mentioned this issue Oct 20, 2018
@zingale
Copy link
Member Author

zingale commented May 17, 2022

These are different enough now in how we do some of the tracing that I am going to close this.

@zingale zingale closed this as completed May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant