Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot compile the flame problem with "USE_SDC=TRUE" #216

Closed
KISSFORMISS opened this issue Oct 9, 2017 · 4 comments
Closed

Cannot compile the flame problem with "USE_SDC=TRUE" #216

KISSFORMISS opened this issue Oct 9, 2017 · 4 comments
Projects

Comments

@KISSFORMISS
Copy link
Contributor

I'm studying the flame model in Castro recently. I would like to compare the SDC method to Strang splitting method we usually used. But when I tried to compile with "USE_SDC=TRUE", it failed with following error message:

Error: Symbol 'eos_get_small_dens' referenced at (1) not found in module 'eos_module'
/home/muhung/Microphysics/integration/BS/bs_type_sdc.F90:56.45:

use eos_module, only: eos_get_small_dens, eos_get_max_dens, eos
                                         1

Error: Symbol 'eos_get_max_dens' referenced at (1) not found in module 'eos_module'
Compiling riemann_1d.F90 ...
/home/muhung/Microphysics/integration/BS/bs_type_sdc.F90:301.30:

use eos_module, only: eos, eos_get_small_temp, eos_get_max_temp
                          1

Error: Symbol 'eos_get_small_temp' referenced at (1) not found in module 'eos_module'
/home/muhung/Microphysics/integration/BS/bs_type_sdc.F90:301.50:

use eos_module, only: eos, eos_get_small_temp, eos_get_max_temp
                                              1

Error: Symbol 'eos_get_max_temp' referenced at (1) not found in module 'eos_module'

@zingale
Copy link
Member

zingale commented Oct 10, 2017

this is because the BS integrator doesn't build anymore with SDC, but VODE is preferred anyway. I'll switch it to VODE.

@zingale
Copy link
Member

zingale commented Oct 10, 2017

actually, BS is the backup integrator, so we need to fix things there

@zingale zingale added this to straightforward but perhaps time consuming / needs thought in hackathon Oct 13, 2017
@zingale
Copy link
Member

zingale commented Oct 14, 2017

this is fixed in StarKiller: AMReX-Astro/Microphysics#57

@zingale zingale moved this from straightforward but perhaps time consuming / needs thought to PR issued in hackathon Oct 16, 2017
@zingale
Copy link
Member

zingale commented Oct 18, 2017

this has been fixed by a combination of me and @dwillcox

@zingale zingale closed this as completed Oct 18, 2017
@zingale zingale moved this from PR issued to completed in hackathon Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
hackathon
completed
Development

No branches or pull requests

2 participants