Sdc fix #57
Merged
Sdc fix #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KISSFORMISS please try the detonation with this change to see if it still behaves like it used to |
|
I'm just looking at this and some of these changes are similar to changes I've made locally, I've pushed some additional fixes. I am good to merge and close this PR, though I haven't tested this with Castro. There are some other issues I've found but I'll defer them to another PR as this one is for fixing compilation issues. |
|
great. This fixes the |
|
but I'm not allowed to "approve" it, since I created the original PR. But Don's changes are good, so I will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows Castro to compile with SDC once again
this will close Castro issue 216