Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort if mass fraction is unphysical #1379

Merged
merged 5 commits into from
Mar 7, 2021

Conversation

maxpkatz
Copy link
Member

PR summary

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@maxpkatz
Copy link
Member Author

Detonation-collision fails because it interpolates the burning on the fine level and that does not natively enforce 0 < X < 1.

@zingale
Copy link
Member

zingale commented Nov 21, 2020

I'll retest just the Detonations.

@zingale
Copy link
Member

zingale commented Nov 21, 2020

actually, I think we need development merged in first.

@maxpkatz maxpkatz marked this pull request as draft December 6, 2020 01:40
@maxpkatz
Copy link
Member Author

maxpkatz commented Dec 6, 2020

Marking as draft until I figure out what to do about the reactions.max_solve_level interpolation issue.

@zingale
Copy link
Member

zingale commented Mar 4, 2021

do we still want to do this?

@maxpkatz
Copy link
Member Author

maxpkatz commented Mar 4, 2021

Definitely. I just didn't want to break my science simulations. But since I'm not currently running those right now, maybe we should just merge this and solve that later.

@maxpkatz maxpkatz marked this pull request as ready for review March 4, 2021 02:12
@zingale
Copy link
Member

zingale commented Mar 4, 2021

tests: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2021-03-03-005/index.html

The SDC detonations fail -- I suspect that we are missing a normalization in that code.

@zingale
Copy link
Member

zingale commented Mar 4, 2021

in particular, these failures are all using VODE for the SDC solver, and we don't seem to have any normalization in the RHS there. For the SDC Newton solve, we do have the normalization.

@zingale zingale merged commit 0d66dca into AMReX-Astro:development Mar 7, 2021
@maxpkatz maxpkatz deleted the abundance_safety_check branch March 7, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants