-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abort if mass fraction is unphysical #1379
Abort if mass fraction is unphysical #1379
Conversation
Detonation-collision fails because it interpolates the burning on the fine level and that does not natively enforce 0 < X < 1. |
I'll retest just the Detonations. |
actually, I think we need |
Marking as draft until I figure out what to do about the reactions.max_solve_level interpolation issue. |
do we still want to do this? |
Definitely. I just didn't want to break my science simulations. But since I'm not currently running those right now, maybe we should just merge this and solve that later. |
tests: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2021-03-03-005/index.html The SDC detonations fail -- I suspect that we are missing a normalization in that code. |
in particular, these failures are all using VODE for the SDC solver, and we don't seem to have any normalization in the RHS there. For the SDC Newton solve, we do have the normalization. |
PR summary
PR checklist
CHANGES
file has been updated, if appropriate