Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue a retry when X is invalid after a hydro update #2121

Merged
merged 1 commit into from
Apr 23, 2022

Conversation

maxpkatz
Copy link
Member

PR summary

(rho X) can be negative after a hydro update even if rho itself is not, for example due to transverse terms being applied near sharp composition gradients. We should retry with a smaller timestep in that scenario.

PR motivation

Closes #1952

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@maxpkatz
Copy link
Member Author

This should address one of the two failure modes identified in #2096 (although it could still lead to an abort if too many subcycles are needed to resolve the problem).

@zingale
Copy link
Member

zingale commented Apr 23, 2022

@zingale zingale merged commit 73a6bfa into AMReX-Astro:development Apr 23, 2022
@maxpkatz maxpkatz deleted the retry_on_invalid_X branch April 23, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants