New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move abundance failure tolerance into the runtime parameters #2131

Merged

zingale merged 1 commit into AMReX-Astro:development from maxpkatz:abundance_failure_tolerance

Apr 24, 2022

Member

maxpkatz commented Apr 24, 2022

PR summary

PR checklist

test suite needs to be run on this PR
this PR will change answers in the test suite to more than roundoff level
all newly-added functions have docstrings as per the coding conventions
the CHANGES file has been updated, if appropriate
if appropriate, this change is described in the docs


          Move abundance failure tolerance into the runtime parameters

070110a

Member

zingale commented Apr 24, 2022

quick tests: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2022-04-24-001/index.html

zingale approved these changes

View reviewed changes

zingale merged commit d899a58 into AMReX-Astro:development

maxpkatz deleted the abundance_failure_tolerance branch

April 24, 2022 18:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment